[3.4] Backport clientv3: Replace balancer with upstream grpc solution #16827
Conversation
chaochn47
force-pushed
the
release-3.4-remove-balancer
branch
4 times, most recently
from
5169fa1
to
73133bf
Compare
|
@chaochn47 please rebase this PR. thx |
…after bumping grpc to 1.26.0. Signed-off-by: Chao Chen <chaochn@amazon.com>
… grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
…ream grpc solution Signed-off-by: Chao Chen <chaochn@amazon.com>
…lient/v3/client.go instead of accessing cfg.Endpoints directly Signed-off-by: Chao Chen <chaochn@amazon.com>
…point scenario Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
release-3.4-remove-balancer
branch
from
73133bf
to
1d4e20b
Compare
|
This PR has been rebased. PTAL one commit at a time, thanks~ |
|
This is a huge PR. Could you break down this PR, such as backporting each PR in the list separately? |
It's doable. Just want to confirm that even if the backported PR introduces bug, it's okay to backport the fix separately, correct? |
I think so. The goal right now is to break down this huge PR to make the reviewing easier. |
First one is out. |
|
@chaochn47 are you still working on backporting the last PR? |
|
Yeah, I will help my colleague @jasdel to finish the remaining gRPC version upgrade to resolve the CVE. Is there a deadline so we can adjust the priorities on our TODO list? |
|
It's a blocker for #16751. I expect it can be resolved asap to unblock the release of 3.4.28 (which includes fixes to two CVEs). Thanks. |
Part of #16740
This PR fully removes etcd customized implementation of gRPC old balancer API without breaking changes.
Backported
#16826 should be merged first and this PR will be rebased on top of that.
This should allow us bump gRPC to v1.51.0 easier in release-3.4 in the follow up PR.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.